Skip to content

Tweak admin redesign 2#15623

Merged
rolf-yoast merged 58 commits intofeature/admin-redesignfrom
tweak-admin-redesign-2
Jul 17, 2020
Merged

Tweak admin redesign 2#15623
rolf-yoast merged 58 commits intofeature/admin-redesignfrom
tweak-admin-redesign-2

Conversation

@rolf-yoast
Copy link
Copy Markdown
Member

Context

  • Ran through the admin restyling with Kai and Rolf, made tweaks where we seemed fit
  • Fixed a couple of issues along the way, missing copy, wrongly styled notifications and a lot of spacing

This is linked to Yoast/javascript#751

Todo

Design

  • Content types
    • All setting labels to "hide/show"
    • Archives to separate collapsibles
  • Width of the content
    • Increase for larger screens
  • Search appearance -> Categories
    • Convert Category URLs to a collapsible box
  • Tools page
    • Introduce tabs instead of the list
    • Transform the current tabs into collapsibles
  • Labels
    • Labels color #444 needs to be #303030
  • Buttons
    • Yellow buy buttons font-weight --> 400 (currently 300)
  • General feedback
    • Fix WordPress general alerts alignment
    • Fix toggle labels: “hide/show” instead of “yes/no”
    • Inconsistent font sizes: “you have 1 hidden problem” is on 1.4em, and “you have 1 hidden notification” is on 16px.
    • General > Features > “Upgrade to premium”, should be “Upgrade to Premium”
  • Every option page
    • Settings saved layout
  • Twitter card
    • Convert to radio buttons
  • Schema person/company
    • Convert to radio buttons
  • Toggles
    • Make the labels clickable (Yes/No)
  • Features page
    • Move the "upsell button" inside the paper

Mobile design

  • Walk through and fix tweaking implications

General finishing up

  • Documentation on this PR: Specify what has been fixed/changed

Summary

This PR can be summarized in the following changelog entry:

  • Visual tweaks to the admin-settings pages

Relevant technical choices:

  • N/A

Test instructions

This PR can be tested by following these steps:

  • Use yarn link-monorepo and check out the branch of that PR
  • Use grunt build:js build:css in the Plugin to build the assets after linking and checking out the branch on the monorepo.
  • Walk through all settings pages and check if they are good enough.
  • Note: Notification center styling is off; needs to be fixed

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

moorscode added 30 commits July 6, 2020 11:34
Remove the table-scrollable
Which does not play nice with the person-dropdown when selecting a user above.
To restore general sanity when switching.
@rolf-yoast rolf-yoast added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 6, 2020
@moorscode
Copy link
Copy Markdown
Contributor

The added styling currently breaks the layout of the collapsibles:
Screen Shot 2020-07-09 at 11 22 29

@moorscode
Copy link
Copy Markdown
Contributor

Also for Archives there is no padding.
Use the Test Helper to enabled these books/movies and their archives.

Screen Shot 2020-07-09 at 11 27 31

@moorscode
Copy link
Copy Markdown
Contributor

The upsell looks good 👍

rolf-yoast and others added 6 commits July 9, 2020 12:46
…ak-admin-redesign-2

# Conflicts:
#	admin/views/class-yoast-feature-toggles.php
#	js/src/components/WordPressUserSelectorSearchAppearance.js
#	js/tests/__snapshots__/advancedSettings.test.js.snap
#	js/tests/components/__snapshots__/LocalSEOUpsell.test.js.snap
#	js/tests/components/__snapshots__/SnippetPreviewSection.test.js.snap
@moorscode
Copy link
Copy Markdown
Contributor

Looks good 👍

@rolf-yoast rolf-yoast merged commit c5a1521 into feature/admin-redesign Jul 17, 2020
@rolf-yoast rolf-yoast deleted the tweak-admin-redesign-2 branch July 17, 2020 12:58
@rolf-yoast rolf-yoast added this to the Admin redesign milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants